Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Plausible to MyECL #237

Merged
merged 8 commits into from
Feb 23, 2024
Merged

Add Plausible to MyECL #237

merged 8 commits into from
Feb 23, 2024

Conversation

julien4215
Copy link
Collaborator

@julien4215 julien4215 commented Dec 16, 2023

The goal of this PR is to measure the number of visits on each module thanks to Plausible.

Not tested on iOS.

@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2023

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 56.04%. Comparing base (ea99eb6) to head (b6eb5d5).

Files Patch % Lines
lib/tools/plausible/plausible.dart 0.00% 22 Missing ⚠️
lib/tools/functions.dart 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
- Coverage   56.46%   56.04%   -0.42%     
==========================================
  Files         159      160       +1     
  Lines        3482     3508      +26     
==========================================
  Hits         1966     1966              
- Misses       1516     1542      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@julien4215 julien4215 marked this pull request as draft December 18, 2023 20:44
Copy link
Member

@maximeroucher maximeroucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems really cool.
How can we test it, because it is only enabled in prod ?

@julien4215
Copy link
Collaborator Author

julien4215 commented Dec 19, 2023

You will need to change prod or alpha to dev in the main.dart.

@maximeroucher maximeroucher added ready for review This PR is ready to be reviewed waiting backend labels Jan 9, 2024
@julien4215 julien4215 marked this pull request as ready for review February 12, 2024 15:26
pubspec.yaml Outdated Show resolved Hide resolved
@julien4215 julien4215 marked this pull request as draft February 13, 2024 10:38
@julien4215 julien4215 marked this pull request as ready for review February 14, 2024 08:02
@julien4215 julien4215 force-pushed the plausible branch 2 times, most recently from fb4c06e to 85c26f8 Compare February 14, 2024 11:12
@guillaumetavernier guillaumetavernier merged commit 4402471 into main Feb 23, 2024
5 checks passed
@guillaumetavernier guillaumetavernier deleted the plausible branch February 23, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants