-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/enabling validator with empty value #290
Merged
guillaumetavernier
merged 4 commits into
main
from
fix/enabling-validator-with-empty-value
Feb 19, 2024
Merged
Fix/enabling validator with empty value #290
guillaumetavernier
merged 4 commits into
main
from
fix/enabling-validator-with-empty-value
Feb 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #290 +/- ##
==========================================
- Coverage 56.58% 56.47% -0.12%
==========================================
Files 160 159 -1
Lines 3492 3483 -9
==========================================
- Hits 1976 1967 -9
Misses 1516 1516 ☔ View full report in Codecov by Sentry. |
guillaumetavernier
approved these changes
Feb 18, 2024
julien4215
force-pushed
the
fix/enabling-validator-with-empty-value
branch
from
February 18, 2024 12:25
ab22ef6
to
1ed9faf
Compare
maximeroucher
commented
Feb 18, 2024
guillaumetavernier
approved these changes
Feb 18, 2024
guillaumetavernier
approved these changes
Feb 19, 2024
julien4215
approved these changes
Feb 19, 2024
guillaumetavernier
deleted the
fix/enabling-validator-with-empty-value
branch
February 19, 2024 09:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #283