Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/enabling validator with empty value #290

Merged
merged 4 commits into from
Feb 19, 2024

Conversation

maximeroucher
Copy link
Member

Close #283

@maximeroucher maximeroucher added the fix bug This PR fix a bug label Feb 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c6fa84d) 56.58% compared to head (a999a38) 56.47%.
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #290      +/-   ##
==========================================
- Coverage   56.58%   56.47%   -0.12%     
==========================================
  Files         160      159       -1     
  Lines        3492     3483       -9     
==========================================
- Hits         1976     1967       -9     
  Misses       1516     1516              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@julien4215 julien4215 force-pushed the fix/enabling-validator-with-empty-value branch from ab22ef6 to 1ed9faf Compare February 18, 2024 12:25
@julien4215 julien4215 added the ready for review This PR is ready to be reviewed label Feb 18, 2024
@guillaumetavernier guillaumetavernier merged commit ffe42b4 into main Feb 19, 2024
6 checks passed
@guillaumetavernier guillaumetavernier deleted the fix/enabling-validator-with-empty-value branch February 19, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix bug This PR fix a bug ready for review This PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impossibility to create new product
4 participants