Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : refresher #380

Merged
merged 1 commit into from
Jun 4, 2024
Merged

fix : refresher #380

merged 1 commit into from
Jun 4, 2024

Conversation

Foukki
Copy link
Contributor

@Foukki Foukki commented Jun 4, 2024

Close #335

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.87%. Comparing base (afe8f5e) to head (e4ce1da).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #380   +/-   ##
=======================================
  Coverage   53.87%   53.87%           
=======================================
  Files         169      169           
  Lines        3727     3727           
=======================================
  Hits         2008     2008           
  Misses       1719     1719           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@maximeroucher maximeroucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, need to be tested on IOS to be sure

Copy link
Member

@armanddidierjean armanddidierjean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great on iOS

@Foukki Foukki merged commit e7f5550 into main Jun 4, 2024
3 checks passed
@Foukki Foukki deleted the fix-ios-refresher branch June 4, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refresher: can not pull to refresh if there are not enough elements on iOS
4 participants