Fix ph vanishing when the app enter background #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #381 +/- ##
=======================================
Coverage 54.01% 54.01%
=======================================
Files 168 168
Lines 3710 3710
=======================================
Hits 2004 2004
Misses 1706 1706 ☔ View full report in Codecov by Sentry. |
| @@ -37,7 +37,7 @@ class PhMainPage extends HookConsumerWidget { | |||
| ), | |||
| const SizedBox(height: 10), | |||
| SizedBox( | |||
| width: MediaQuery.of(context).size.width - 60, | |||
| width: 250, | |||
There was a problem hiding this comment.
Have you tested this on different screen format ?
There was a problem hiding this comment.
250 pixels is really small there won't be any problems (I can't really test on little screen format)
armanddidierjean
changed the title
BirdieECL
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require #380