[WIP] Mac refactor demo 2019 #771
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
December 28, 2017 14:49
- add synctriplet - move sync repo independent package - move config to independent package - sync machine todo
…iting list to handle this case
…der's remote path
…ate new file or folder under the deleted one
added 8 commits
March 7, 2019 15:14
… add new file problem
get parent of file in the root folder's bug
|
|
||
| namespace CmisSync.Lib.Sync.SyncMachine | ||
| { | ||
| public class SyncTripletProcessor |
There was a problem hiding this comment.
Class documentation would be great :-)
| return res; | ||
| } | ||
|
|
||
| public static SyncTriplet CreateSFGFromLocalFolder( |
There was a problem hiding this comment.
Expanding SFG (or at least explaining it) would make the code more understandable to readers.
| <Compile Include="Config\CmisSyncConfig.cs" /> | ||
| <Compile Include="Config\ConfigManager.cs" /> | ||
| <Compile Include="Config\ConfigMigration.cs" /> | ||
| <Compile Include="Sync\SynchronizeItem\SyncItem.cs" /> |
There was a problem hiding this comment.
SynchronizeItem -> SynchronizedItem?
| metadata = OperationUtils.FetchMetadata (remoteDocument, session); | ||
| } catch (CmisBaseException e) { | ||
| // Remove temporary local document to avoid it being considered a new document. | ||
| Console.WriteLine (" %% download error, " + e.Message); |
There was a problem hiding this comment.
Why not to the log file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on 2017/12's old version.
Crawlsync tested, changlog sync tested for basic behavior. Local watcher not implemented yet