New icon: Rakuten #805
Merged
New icon: Rakuten #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dampypena
force-pushed
the
add-rakuten-icon
branch
from
2ce81fe
to
2af391a
Compare
krisu5
requested changes
Jan 15, 2023
There was a problem hiding this comment.
I got the logo from their Facebook page and I converted it in SVG with Convertio. I had to do small modifications in Inkscape to have a clean logo.
Replace the logo with SVG from branding guidelines page ("Télécharger notre logo" button, in the ZIP's /RVB/RED folder).
Also use full logo, don't make it just "R".
P.S. Read my note about image tracing in the your other PR.
The color was taken from the header of the website #bf0000
Use logo's color.
Dampypena
force-pushed
the
add-rakuten-icon
branch
from
2af391a
to
5c563b5
Compare
|
I replaced the logo with https://corp.rakuten.co.jp/assets/img/common/logo.svg. The logo color is also |
krisu5
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL of the site:
https://fr.shopping.rakuten.com/
Proof of the Aegis-compatible 2FA:
Logo / icon info:
I got the logo from their Facebook page and I converted it in SVG with Convertio. I had to do small modifications in Inkscape to have a clean logo.
Background color info:
The color was taken from the header of the website
#bf0000