Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Use travis_retry with stack setup #330

Merged
merged 2 commits into from
Jul 11, 2019
Merged

Use travis_retry with stack setup #330

merged 2 commits into from
Jul 11, 2019

Conversation

neongreen
Copy link
Member

No description provided.

@neongreen neongreen requested a review from willbasky July 11, 2019 15:12
@@ -45,7 +45,7 @@ jobs:
before_script:
- sudo apt-get install -y libgmp-dev
- curl -sSL https://get.haskellstack.org/ | sh
- stack setup
- travis_retry stack setup
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From instruction: "If you are getting network timeouts when trying to download dependencies, either use the built in retry feature of your dependency manager or wrap your install commands in the travis_retry function."
My problem travis was with unfree directory to unpack (or install), it didn't concern network timeouts.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Network timeouts are one usecase but I think it's not the only one.

The "unfree directory to unpack" thing is a Stack bug: commercialhaskell/stack#4888. It happens for a different reason – if you look closely at the error message, it doesn't actually say that it failed because the directory wasn't empty, it says that unpacking failed and now the directory may not be empty.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, travis_retry is here for what reason? Just workaround?

Copy link
Contributor

@willbasky willbasky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do it.

@neongreen neongreen merged commit f305063 into develop Jul 11, 2019
@neongreen neongreen deleted the travis_retry branch July 11, 2019 16:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants