Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ".spec.image" #48

Closed
kvaps opened this issue Mar 20, 2024 · 3 comments · Fixed by #63
Closed

Implement ".spec.image" #48

kvaps opened this issue Mar 20, 2024 · 3 comments · Fixed by #63
Labels
enhancement New feature or request
Milestone

Comments

@kvaps
Copy link
Member

kvaps commented Mar 20, 2024

Internaly we agreed to extend spec like this:

 ---
 apiVersion: etcd.aenix.io/v1alpha1
 kind: EtcdCluster
 metadata:
   name: test
   namespace: ns1
 spec:
+  image: "quay.io/coreos/etcd:v3.5.12"
   replicas: 3
 status:
   conditions:
   - lastProbeTime: null
 	lastTransitionTime: "2024-03-06T18:39:45Z"
 	status: "True"
 	type: Ready
@kvaps kvaps added this to the v0.0.2 milestone Mar 20, 2024
@sircthulhu sircthulhu self-assigned this Mar 23, 2024
@AlexGluck
Copy link
Collaborator

AlexGluck commented Mar 24, 2024

I suggest before accept PR #63 move key image under podSpec.

@gecube
Copy link
Collaborator

gecube commented Mar 24, 2024

Agree with @AlexGluck that two keys would be too much. From the other point of view - podSpec is redundant for us. And we can just use the subset of keys from there like affinity, tolerations etc., which are important and should be customisable by the end user. But it will lead to massive work for preparing our own version of spec. Or otherwise we can just use podSpec and fill the proper spec fields by admission controller. So effectively taking spec.image and putting it into proper place of podSpec.

Why do I so insist on using spec.image? Because it is obviuos that it is much more important and more frequent to be changed than other fields from podSpec. So logically it should as close to the root key spec as possible.

@sergeyshevch
Copy link
Member

For now we have 2 options about field placement:

  • spec.image
  • spec.podSpec.image

We will decide it with community vote in https://t.me/etcd_operator/4054 and comment decision here

@sergeyshevch sergeyshevch added the enhancement New feature or request label Mar 25, 2024
sircthulhu added a commit that referenced this issue Mar 26, 2024
Added `image` field to PodSpec of EtcdCluster spec, added tests and implemented
defaulting webhook.
fixes #48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants