[DEP] Deprecate the ACF and PACF BaseTransformer wrappers #1473
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as part of #1446, replacing these thin wrappers with BaseSeriesTransformer wrappers, and we also provide our own cut down ACF function (with PACF to follow) through deprecation
Two things to note: neither of these wrappers handled soft dependencies in the standard way, and I have converted to internal numpy, since statsmodels simply converts to numpy itself internally and makes no use of an index.
p.s. changed two typos in other deprecation messages I came across along the way. Changed the names until deprecation because it confuses the CI having two classes with the same name