Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEP] Deprecate the ACF and PACF BaseTransformer wrappers #1473

Merged
merged 6 commits into from
May 20, 2024
Merged

Conversation

TonyBagnall
Copy link
Contributor

@TonyBagnall TonyBagnall commented Apr 24, 2024

as part of #1446, replacing these thin wrappers with BaseSeriesTransformer wrappers, and we also provide our own cut down ACF function (with PACF to follow) through deprecation

Two things to note: neither of these wrappers handled soft dependencies in the standard way, and I have converted to internal numpy, since statsmodels simply converts to numpy itself internally and makes no use of an index.

p.s. changed two typos in other deprecation messages I came across along the way. Changed the names until deprecation because it confuses the CI having two classes with the same name

@TonyBagnall TonyBagnall added transformations Transformations package deprecation This issue is related to deprecation or removal of code labels Apr 24, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I would have added the following labels to this PR based on the changes made: [ $\color{#BCAE15}{\textsf{classification}}$, $\color{#7E0206}{\textsf{regression}}$, $\color{#41A8F6}{\textsf{transformations}}$ ], however some package labels are already present.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

@TonyBagnall TonyBagnall merged commit 0e025d7 into main May 20, 2024
15 checks passed
@TonyBagnall TonyBagnall deleted the ajb/acf branch May 20, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation This issue is related to deprecation or removal of code transformations Transformations package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants