Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] unexclude mock forecaster #1609

Merged
merged 2 commits into from
Jun 7, 2024
Merged

[BUG] unexclude mock forecaster #1609

merged 2 commits into from
Jun 7, 2024

Conversation

TonyBagnall
Copy link
Contributor

@TonyBagnall TonyBagnall commented Jun 5, 2024 •
edited
Loading

Fixes #1067 which no longer seems an issue

@TonyBagnall TonyBagnall added bug Something isn't working forecasting Forecasting package labels Jun 5, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I would have added the following labels to this PR based on the changes made: [ $\color{#2C2F20}{\textsf{testing}}$ ], however some package labels are already present.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

@TonyBagnall TonyBagnall added full pytest actions Run the full pytest suite on a PR codecov actions Run the codecov action on a PR labels Jun 5, 2024
@TonyBagnall TonyBagnall marked this pull request as ready for review June 6, 2024 07:45
@TonyBagnall TonyBagnall merged commit 34f1138 into main Jun 7, 2024
22 checks passed
@TonyBagnall TonyBagnall deleted the ajb/mock_forecaster branch June 7, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthewMiddlehurst MatthewMiddlehurst MatthewMiddlehurst approved these changes

@chrisholder chrisholder Awaiting requested review from chrisholder

@hadifawaz1999 hadifawaz1999 Awaiting requested review from hadifawaz1999

@ltsaprounis ltsaprounis Awaiting requested review from ltsaprounis

Assignees
No one assigned
Labels
bug Something isn't working codecov actions Run the codecov action on a PR forecasting Forecasting package full pytest actions Run the full pytest suite on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] MockUnivariateForecasterLogger fails test_non_state_changing_method_contract
2 participants
@TonyBagnall @MatthewMiddlehurst