New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Update dtw distance #316
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2d69ca4.
chrisholder
added
enhancement
New feature, improvement request or other non-bug code enhancement
distances
Distances package
labels
Apr 21, 2023
4 tasks
TonyBagnall
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
went through this with chris today, looks good to me
This was referenced Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
distances
Distances package
enhancement
New feature, improvement request or other non-bug code enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
This pr depends on pr #308 and pr #309
What does this implement/fix? Explain your changes.
This pr updates dtw to the new format for distances. In addition in doing so it makes optimisations for computing the distances between multiple time series.
Additionally, this pr also removes the checks for if functions are compiled to numba.
Does your contribution introduce a new dependency? If yes, which one?
What should a reviewer concentrate their feedback on?
Did you add any tests for the change?
There are two new test files that extend testing to cost matrix and alignment paths.
Any other comments?
The reason the removing of the checks if things are compiled to numba has been removed in this is pr is because previously bugs with alignment paths and cost matrix had slipped through testing when compiled to numba. This is because while numba is active bounds check is turned off and as such bugs that would normally throw an error (accessing an index out of bounds of the array) dont throw errors. This has previously allowed tests that go out of bounds slip through testing and therefore it was important to test all the new distances with numba turned on and off to ensure they are working.
PR checklist
For all contributions