Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Update dtw distance #316

Merged
merged 60 commits into from Apr 24, 2023
Merged

[ENH] Update dtw distance #316

merged 60 commits into from Apr 24, 2023

Conversation

chrisholder
Copy link
Contributor

Reference Issues/PRs

This pr depends on pr #308 and pr #309

What does this implement/fix? Explain your changes.

This pr updates dtw to the new format for distances. In addition in doing so it makes optimisations for computing the distances between multiple time series.

Additionally, this pr also removes the checks for if functions are compiled to numba.

Does your contribution introduce a new dependency? If yes, which one?

What should a reviewer concentrate their feedback on?

Did you add any tests for the change?

There are two new test files that extend testing to cost matrix and alignment paths.

Any other comments?

The reason the removing of the checks if things are compiled to numba has been removed in this is pr is because previously bugs with alignment paths and cost matrix had slipped through testing when compiled to numba. This is because while numba is active bounds check is turned off and as such bugs that would normally throw an error (accessing an index out of bounds of the array) dont throw errors. This has previously allowed tests that go out of bounds slip through testing and therefore it was important to test all the new distances with numba turned on and off to ensure they are working.

PR checklist

For all contributions
  • I've added myself to the list of contributors.
  • Optionally, I've updated aeon's CODEOWNERS to receive notifications about future changes to these files.
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG] indicating whether the PR topic is related to enhancement, maintenance, documentation, or bug.
  • For new estimators, I've added the estimator to the online documentation.

@chrisholder chrisholder added enhancement New feature, improvement request or other non-bug code enhancement distances Distances package labels Apr 21, 2023
@chrisholder chrisholder mentioned this pull request Apr 22, 2023
4 tasks
@chrisholder chrisholder mentioned this pull request Apr 23, 2023
4 tasks
@chrisholder chrisholder mentioned this pull request Apr 23, 2023
4 tasks
Copy link
Contributor

@TonyBagnall TonyBagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

went through this with chris today, looks good to me

@TonyBagnall TonyBagnall merged commit 5683099 into main Apr 24, 2023
16 checks passed
@TonyBagnall TonyBagnall deleted the update-dtw-distance branch April 24, 2023 20:59
This was referenced Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distances Distances package enhancement New feature, improvement request or other non-bug code enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants