Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP/POC] Functional daemon/simplewallet with minimal changes #2

Closed
wants to merge 20 commits into from

Conversation

stoffu
Copy link

@stoffu stoffu commented Feb 7, 2018

Not totally confident with the whole codebase (particularly with verification/hardfork/checkpoints), but I just wanted to try anyway out of curiosity. Hopefully this will be useful as a starting point.

The following are confirmed:

  • The rebased aeond syncs from scratch through the hardfork height 592000 to the current top ~921400
  • The old simplewallet can connect to the rebased aeond to make transactions
  • The new aeon-wallet-cli can connect to the rebased aeond to make transactions

ToDo:

  • Make sure the consensus rule remains the same (e.g. no RingCT)
    • Seems OK, but needs more thorough check and testing
  • Testnet --> done in Even more minimal version #4
  • Compatibility of wallet seeds --> My misunderstanding: conversion of old-style seed into new one is already handled in Monero.
  • Correct display of difficulty/hashrate --> fixed
  • Fee multiplier
    • (Probably not worthwhile since the current flat fee will become obsolete soon)
  • Test other executables (wallet-rpc, blockchain-import/export) --> confirmed working
  • Update tests (hash, difficulty, etc) --> mostly done
  • Misc: README, copyright, versioning, etc
    • (Probably outside the scope of this patch)

@drparadoxical
Copy link

Convenient that you're submitting this, as we just finished up work ourselves. Also convenient how all of your commits are made within the last 24 hours.

You've clearly lifted from https://github.com/drparadoxical/aeon-rebase in order to try and sprint for the finish line.

At the very least, I will ensure the facts are known, publicly, and to all involved.

@greenbay121982
Copy link

greenbay121982 commented Feb 7, 2018

Straight up stole from us. Stoffu, come on man you are well known in the community.

@stoffu
Copy link
Author

stoffu commented Feb 7, 2018

@drparadoxical @greenbay121982

Yes, I've been watching your repository, and I've also built your branch (forgot which commit) and tried to run it, to no avail (it didn't start syncing with other peers). You may not believe me, but the truth is that I didn't use/copy your code (which TBH looked quite verbose to me with lots of copyright/renaming changes) and implemented everything literally on my own with minimalism/simplicity as the top priority (as I've been doing for other patches in the past).

EDIT
I did it in one day and a half because I sensed a bit of urgency in @iamsmooth's comment on Reddit:

So, please, all participants please complete your rebase efforts and make a submission of working code (according to the existing AEON consensus rules) ASAP. There has already been one submission that is largely functional. I have stated previously that there can be multiple submissions and multiple winners but that timeline is not unlimited.

I anticipated the possibility of this kind of drama, especially considering your talkative character, and I never want to be involved with it and can't waste my time for it. This is why I'm still quite against the idea of raising a huge bounty for such an important task as this rebase. Therefore, I resign from the bounty race and refuse to receive any reward. @iamsmooth clearly stated that there could be multiple winners, so don't worry about any of your share being stolen by me because I'm not participating.

I just made this patch to make sure that the community sees what I consider to be a reasonable patch for the rebase, which can be taken just in case patches from other groups like yours ended up being problematic for some reason.

@drparadoxical
Copy link

Honesty. Thank you. Since you insist on being a gentleman, I'll do the same.

Your code is almost identical to what we've written. Almost.

You put forth specific additions in your PR which I believe may be useful to this work if and when presented with a specific situation. That is, if and when the rebase is decided to bypass any new way of computing transaction fees or ensuring minimum relay fees, and simply use the explicitly defined values currently in place for AEON v0.9.14.0, then your PR just now has that, specifically, as an underlying assumption.

That said, because you've outed yourself as an honest gentleman, I refuse to accept your resignation. As per the paragraph above, there's specific contribution you've put forth that's outside of code we've written.

@greenbay121982
Copy link

Thanks for being a gentleman.

@abhishek1104
Copy link

abhishek1104 commented Feb 8, 2018

Great job @stoffu
The thing is simple we want a successful rebase as soon as possible as we are left behind and hope your implementation can help to finish it ASAP.
Also i wish post successful rebase ,in future we have something like ARL -- Aeon Research Lab ,and you are its member 👍

@greenbay121982 @drparadoxical
You both also doing great job,i watch your git regularly.

Anyways i think together this goal can be achieved sooner.Also guys please finish your pending issues ASAP and do submit it for bounty.Ready to contribute to testing once its released for community testing.

@stoffu stoffu force-pushed the aeon-rebase branch 3 times, most recently from 88ab155 to 6b70023 Compare February 9, 2018 12:56
@stoffu
Copy link
Author

stoffu commented Feb 9, 2018

The way Aeon did the hardfork is quite different from that of Monero. In particular, the block version didn't change after the fork height 592000 which is hardcoded in cryptonote_config.h, whereas in Monero the fork heights are given in cryptonote_core/blockchain.cpp and separately for the mainnet vs. testnet. I think we need to come up with a reasonable way to incorporate Aeon's 592000 fork into the Monero-style fork mechanism.

A question to start with: Should the testnet fork at the same height 592000 and change the slow hash and the diff target the exact same way as in the mainnet (which I find a reasonable approach)?

@stoffu stoffu force-pushed the aeon-rebase branch 2 times, most recently from 9a391a5 to b7916c0 Compare February 9, 2018 14:45
@stoffu
Copy link
Author

stoffu commented Feb 14, 2018

Closing in favor of #4.

@stoffu stoffu closed this Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants