-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP/POC] Functional daemon/simplewallet with minimal changes #2
Conversation
…ine below-std fee transactions only half the time (1e743dc)
Convenient that you're submitting this, as we just finished up work ourselves. Also convenient how all of your commits are made within the last 24 hours. You've clearly lifted from https://github.com/drparadoxical/aeon-rebase in order to try and sprint for the finish line. At the very least, I will ensure the facts are known, publicly, and to all involved. |
Straight up stole from us. Stoffu, come on man you are well known in the community. |
@drparadoxical @greenbay121982 Yes, I've been watching your repository, and I've also built your branch (forgot which commit) and tried to run it, to no avail (it didn't start syncing with other peers). You may not believe me, but the truth is that I didn't use/copy your code (which TBH looked quite verbose to me with lots of copyright/renaming changes) and implemented everything literally on my own with minimalism/simplicity as the top priority (as I've been doing for other patches in the past). EDIT
I anticipated the possibility of this kind of drama, especially considering your talkative character, and I never want to be involved with it and can't waste my time for it. This is why I'm still quite against the idea of raising a huge bounty for such an important task as this rebase. Therefore, I resign from the bounty race and refuse to receive any reward. @iamsmooth clearly stated that there could be multiple winners, so don't worry about any of your share being stolen by me because I'm not participating. I just made this patch to make sure that the community sees what I consider to be a reasonable patch for the rebase, which can be taken just in case patches from other groups like yours ended up being problematic for some reason. |
Honesty. Thank you. Since you insist on being a gentleman, I'll do the same. Your code is almost identical to what we've written. Almost. You put forth specific additions in your PR which I believe may be useful to this work if and when presented with a specific situation. That is, if and when the rebase is decided to bypass any new way of computing transaction fees or ensuring minimum relay fees, and simply use the explicitly defined values currently in place for AEON v0.9.14.0, then your PR just now has that, specifically, as an underlying assumption. That said, because you've outed yourself as an honest gentleman, I refuse to accept your resignation. As per the paragraph above, there's specific contribution you've put forth that's outside of code we've written. |
Thanks for being a gentleman. |
Great job @stoffu @greenbay121982 @drparadoxical Anyways i think together this goal can be achieved sooner.Also guys please finish your pending issues ASAP and do submit it for bounty.Ready to contribute to testing once its released for community testing. |
Fix no new line
88ab155
to
6b70023
Compare
The way Aeon did the hardfork is quite different from that of Monero. In particular, the block version didn't change after the fork height 592000 which is hardcoded in A question to start with: Should the testnet fork at the same height 592000 and change the slow hash and the diff target the exact same way as in the mainnet (which I find a reasonable approach)? |
9a391a5
to
b7916c0
Compare
Wallet caches and keys files are loaded with chacha8 as needed, but only saved with chacha20. Other data (eg, cold wallet data files, etc) will be incompatible.
Closing in favor of #4. |
Not totally confident with the whole codebase (particularly with verification/hardfork/checkpoints), but I just wanted to try anyway out of curiosity. Hopefully this will be useful as a starting point.
The following are confirmed:
aeond
syncs from scratch through the hardfork height 592000 to the current top ~921400simplewallet
can connect to the rebasedaeond
to make transactionsaeon-wallet-cli
can connect to the rebasedaeond
to make transactionsToDo:
Testnet--> done in Even more minimal version #4Compatibility of wallet seeds--> My misunderstanding: conversion of old-style seed into new one is already handled in Monero.Correct display of difficulty/hashrate--> fixedTest other executables (wallet-rpc, blockchain-import/export)--> confirmed workingUpdate tests (hash, difficulty, etc)--> mostly done