-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Let the ingress-gateway uses the same port as the business service as a proxy for layer 7 traffic. #318
Conversation
Signed-off-by: panniyuyu@gmail.com <panniyuyu@gmail.com>
Signed-off-by: panniyuyu@gmail.com <panniyuyu@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me, some nits. Thanks.
OK, i will address these suggestions later. Thanks for reviewing. @Xunzhuo |
Signed-off-by: panniyuyu@gmail.com <panniyuyu@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add the gateway e2e test to the github workflow?
Thank you, @panniyuyu, for contributing this incredibly useful feature! I just wanted to let you know that since this PR is relatively large, it may take me some time to review and fully understand all of the changes. However, I really appreciate your hard work and am excited to see how this feature can improve our projec |
Sure, i will finish it later. |
Signed-off-by: panniyuyu@gmail.com <panniyuyu@gmail.com>
Signed-off-by: panniyuyu@gmail.com <panniyuyu@gmail.com>
@panniyuyu Great job on the PR! I have reviewed it and everything looks good to me. Have you been able to identify the root cause of the failed gateway test? Once you have fixed the gateway test, yamllint errors, and golang lint errors, we will be able to merge your changes into the master branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Side comment, we need a document to decribe this new feature, thanks.
The documentation is not a blocker and can be added separately through another PR. |
Signed-off-by: panniyuyu@gmail.com <panniyuyu@gmail.com>
Signed-off-by: panniyuyu@gmail.com <panniyuyu@gmail.com>
I have aready fixed the gateway test, yamllint errors. But i have no idea about golang lint errors. Could you please do me a favor? @zhaohuabing |
golang lint checks the order of import packages. This should be fixed with: goimports -local github.com/aeraki-mesh/aeraki ./... |
Signed-off-by: panniyuyu@gmail.com <panniyuyu@gmail.com>
This PR is the implementation of #303 |
Let the ingress-gateway uses the same port as the business service as a proxy for layer 7 traffic.