Refactory: move api and client-go to standalone repos #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaohuabing
changed the title
zhaohuabing
force-pushed
the
move-out-api
branch
2 times, most recently
from
5b758d4
to
3a5033d
Compare
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
…t public packages Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
zhaohuabing
force-pushed
the
move-out-api
branch
from
c6ee5ca
to
15b8391
Compare
zhaohuabing
force-pushed
the
move-out-api
branch
from
775582c
to
e146509
Compare
tanjunchen
reviewed
Jul 30, 2023
| dubborulepb "github.com/aeraki-mesh/aeraki/api/dubbo/v1alpha1" | ||
| dubboapi "github.com/aeraki-mesh/aeraki/client-go/pkg/apis/dubbo/v1alpha1" | ||
| dubboclient "github.com/aeraki-mesh/aeraki/client-go/pkg/clientset/versioned/typed/dubbo/v1alpha1" | ||
| dubborulepb "github.com/aeraki-mesh/api/dubbo/v1alpha1" |
There was a problem hiding this comment.
这些包的导入顺序建议按照
golang 内置包、第三方依赖、项目依赖包顺序，其他的也同理。
| google.golang.org/protobuf v1.30.0 | ||
| istio.io/api v1.19.0-alpha.1 | ||
| istio.io/client-go v1.18.1 | ||
| istio.io/gogo-genproto v0.0.0-20230705213215-8f59b5a7ddde |
There was a problem hiding this comment.
我们还使用 istio.io/gogo-genproto 这个包？我看 istio 现在不依赖这个包了。
There was a problem hiding this comment.
It's used in api, which is deprecated.
| golang.org/x/sync v0.3.0 | ||
| google.golang.org/grpc v1.54.0 | ||
| google.golang.org/protobuf v1.30.0 | ||
| istio.io/api v1.19.0-alpha.1 |
There was a problem hiding this comment.
istio.io/api 建议使用 istio 1.16.x 版本，目前 istio 最新的 tag 版本是 1.16.7 .
There was a problem hiding this comment.
Thanks for the review. I'll address these comments in another PR.
There was a problem hiding this comment.
This import is generated by go tidy, and has been replaced by 1.16.7
replace istio.io/api => istio.io/api v0.0.0-20230518153929-d0aebaa77ab8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move Aeraki API to https://github.com/aeraki-mesh/api
Move Aeraki API client go lib to https://github.com/aeraki-mesh/client-go
The API and client-go packages inside Aeraki repo will be keep for a while to avoid any breaking changes to projects that depend on Aeraki.
All the Istio dependencies have also been updated to 1.16.5 .