Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RPC] Support to get name at a specific number of block #78

Merged
merged 1 commit into from May 16, 2019
Merged

[RPC] Support to get name at a specific number of block #78

merged 1 commit into from May 16, 2019

Conversation

kjunu
Copy link
Contributor

@kjunu kjunu commented May 16, 2019 •
edited

@kjunu kjunu requested a review from graup May 16, 2019 05:29
@graup
Copy link
Member

graup commented May 16, 2019

looks ok to me

@graup
Copy link
Member

graup commented May 16, 2019

I especially like the use of the AccountStateReader interface 👍

@kjunu kjunu mentioned this pull request May 16, 2019
Merged
@ashen1dev ashen1dev merged commit eb6296c into develop May 16, 2019
@kjunu kjunu deleted the topic/name/blockno branch May 21, 2019 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graup graup graup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kjunu @graup @ashen1dev