AGCORDOVA-158 (Android) Push not reflecting metrics when launching a … #113
Conversation
…stopped application
| @@ -230,7 +229,7 @@ private PushRegistrar getPushRegistrar() { | |||
| */ | |||
| public static void sendMessage(Bundle message) { | |||
| if (message != null) { | |||
| if (sendMetrics && !foreground) { | |||
| if (sendMetrics && (!foreground || cachedMessage != null)) { | |||
There was a problem hiding this comment.
why do you need this check? cachedMessage is not used inside the if
There was a problem hiding this comment.
It's explained in the description of the PR. When the app is fully closed and you open it from a push, first time the message is cached but not processed, and when the plugin is ready and the app calls register again, then checks if there is a cached message and process it, but the app is in foreground, so the received confirmation is not sent. With this check we can know if the app was launched from a push message.
|
@edewit @jcesarmobile should we run another community release ? |
|
yeah, because last release is from September Also, some of the changes should be done against 3.0.x-cdv-droid411 branch too |
…stopped application
When the app is fully closed and you open it from the push message, at first the webview is not ready to execute code, so the message is cached. Once Cordova is ready and register is called, the app is in foreground, so the metric is not sent.
Changed to also check if cachedMessage is not null, that means that the app was launched from a push message while fully closed