Decouple service creation from MobileCore #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -70,7 +70,7 @@ OpenIDAuthenticationProvider provideAuthProvider(KeycloakAuthenticateProviderImp | |||
| // tag::securityServiceInit[] | |||
| @Provides @Singleton | |||
| SecurityService provideSecurityService() { | |||
| return MobileCore.getInstance().getService(SecurityService.class); | |||
| return new SecurityService(); | |||
There was a problem hiding this comment.
👍 Cleaner and shows easier to be used.
|
@secondsun @wei-lee Wanna review before I move forward? |
wei-lee
approved these changes
Aug 14, 2018
ziccardi
approved these changes
Aug 14, 2018
| AuthServiceConfiguration authServiceConfig = new AuthServiceConfiguration.AuthConfigurationBuilder() | ||
| .withRedirectUri("com.aerogear.androidshowcase:/callback") | ||
| .build(); | ||
|
|
||
| authService.init(context, authServiceConfig); | ||
| AuthService authService = new AuthService(authServiceConfig); | ||
| return authService; |
There was a problem hiding this comment.
This could be changed to return new AuthService(authServiceConfig);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues:
PS: This PR depends on aerogear/aerogear-android-sdk#269