New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add metric for total number of requests #90
Comments
@xinau That sounds reasonable. But if the goal is assessing the health, wouldn't a rate on the response errors also do the job? |
@pb82 Using the error rate can be misleading. I.x. I do know when there is a larger response errors than expected, but this could also be the case when the overall traffic went up and shouldn't need to worry me in the case the error to total response ratio remains the same. If it's okay with you I can provide a timely patch and tests. |
issue: aerogear#90 this change adds a new metric for reporting the total number of requests that where made and not only the number of failed requests. this makes it possible to calculate the ratio of errors to total number of requests.
issue: aerogear#90 this change adds a new metric for reporting the total number of requests that where made and not only the number of failed requests. this makes it possible to calculate the ratio of errors to total number of requests.
issue: aerogear#90 this change adds a new metric for reporting the total number of requests that where made and not only the number of failed requests. this makes it possible to calculate the ratio of errors to total number of requests.
currently only response errors are counted, while this it self is useful it would be more complete to also log the total number of requests. by comparing the ratio of errors and total requests a operator is able to determine the healthiness of their installations.
the concrete change needs to be made somewhere along these lines. i'm still unsure how to implement it "correctly", but would like to contribute to the project. 2 solutions that come to my mind would be to either.
keycloak_responses_total
similar tokeycloak_response_errors
that counts all responseskeycloak-metrics-spi/src/main/java/org/jboss/aerogear/keycloak/metrics/MetricsFilter.java
Lines 44 to 48 in a9ede42
The text was updated successfully, but these errors were encountered: