added metric for number of total responses #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinau
force-pushed
the
feature/add-total-response-count-metric
branch
from
6b0c262
to
e9f8950
Compare
issue: aerogear#90 this change adds a new metric for reporting the total number of requests that where made and not only the number of failed requests. this makes it possible to calculate the ratio of errors to total number of requests.
xinau
force-pushed
the
feature/add-total-response-count-metric
branch
from
daccc43
to
c280dd7
Compare
|
@pb82 I hope I'm not bothering, but any chances that we could get this merged soonish? :) |
|
@xinau Sorry for the late response. I will release within this week and try to include your PR. Thanks! |
|
@pb82 Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The ability to calculate the ratio of errors to total number of requests. see #90.
What
This PR adds a new metric for reporting the total number of requests that where made in a addition to the number of failed requests.
How
This was done similar to the number of failed requests.
Verification Steps
A new metric
keycloak_response_totalshould be reported.Checklist:
Progress