Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade gradle wrapper, use implementation instead of compile #109

Merged
merged 1 commit into from
Sep 5, 2021

Conversation

gmodzelewski
Copy link
Contributor

Motivation

#106

  • build works with gradle 7

What

  • gradle wrapper is upgraded
  • changed "compile" to "implementation" in build.gradle

Why

  • "compile" is deprecated since gradle 4
  • build didn't work on my machine and I wanted to fix that.

How

  • Changed build.gradle "compile" statements
  • upgraded the gradle wrapper

Verification Steps

  1. Go to project root
  2. Run "./gradlew jar"
  3. Check if build was successful

Checklist:

  • Code has been tested locally by PR requester
  • Changes have been successfully verified by another team member

Progress

  • Change statements in build gradle
  • Upgrade gradle wrapper

Additional info

Wanted to create a JIRA ticket, because I didn't find any similar existing one. Registration process didn't work. Wrote an email to the red hat customer service. So, this (quite small issue) does not have a ticket yet.

@pb82
Copy link
Contributor

pb82 commented Aug 30, 2021

thanks @gmodzelewski ! I'll give that a try and merge asap!

@pb82 pb82 merged commit 2dcf302 into aerogear:master Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants