feat(Allow usage of apply command for App CR) : Rebind without the need to delete and create again

[camilamacedo86]

Motivation

https://issues.jboss.org/browse/AEROGEAR-9268

What

• Ensure that always will have just 1 ConfigMap created with the latest name of APP CR
• Allow usage of the apply command
• Fix debug after all changes.
• Fix/improve tests after rebase
• Use the model from MSS instead of duplicate it.
• Upgrade operator-sdk from 0.7.0 to the latest version available 0.8.1

Verification Steps

Use the image: docker.io/cmacedo/mobile-security-service-operator:AEROGEAR-9268

1. Install the oper
2. Create the app in the specific namespace
3. Check that a configMap was created for this app
4. Update the name into the Example APP CR
5. Run the command make create-app again
6. It should have just one confgMap with the new name and not 2.

Checklist:

• Code has been tested locally by PR requester
• Changes have been successfully verified by another team member

Progress

• Finished task
• TODO

Additional Notes

[damienomurchu]

combine both with cmd/manager/* ?

[camilamacedo86]

Hi @damienomurchu,

Tks for your time. Unfortunately, it is not possible. The main.go is in this dir.

[damienomurchu]

Changes look good, needs a rebase which you know.

Haven't verified changes, or run tests yet

[davidffrench]

Good work @camilamacedo86 . Just reviewed the code, will verify once items are addressed.

[davidffrench]

@camilamacedo86 Since the mssInstance is initalised as &mobilesecurityservicev1alpha1.MobileSecurityService{} https://github.com/aerogear/mobile-security-service-operator/pull/103/files#diff-f0c3b61d21a85c4c894842a29ca22af2R151 . Is there a possibility that the mssInstance will ever be nil? And if there is, in what scenario will it be nil?

The way I read this logic is that if the mssInstance is nil and the app CR is not marked for deletion, it will still be deleted. This could be very dangerous if the mssInstance is returned as nil in a case where we do not want to delete the app CR.

[camilamacedo86]

The MSS will just be nill when the Service CR/CRD was deleted from the cluster, so if the mss instance is nil each means that we should allow deleting the APP CR.

[davidffrench]

This is the only scenario where it can be nil?

[camilamacedo86]

Yes. I cannot see any other scenario for the MSS be nil. Are you able to see any other scenario?

[laurafitzgerald]

@camilamacedo86 I've completed the verification steps and the changes are working as expected based on the second last commit. I see there are some feedback items and the build is failing on a new commit now so I haven't added an approve yet. I added a verified label. Feel free to ping me when you want a recheck.

[damienomurchu]

Reviewed code & re-verified functionality. Approving as seems you clarified all PR comments and don't see a reason not to approve now