This repository has been archived by the owner on Dec 18, 2019. It is now read-only.
tests(serviceapp): adds validations.go coverage (AEROGEAR-8951) #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi it is already done here: #103 |
@camilamacedo86 I didn't realise you were working on these tests. Just looking at the test coverage added by this PR, and it will increase the coverage higher than the tests in your PR: Test coverage for #103 (from coveralls UI): Test coverage for this PR (#104): I suggest we merge in this PR, and then add the coverage from your PR when it gets merged |
damienomurchu
requested review from
camilamacedo86,
craicoverflow and
davidffrench
camilamacedo86
approved these changes
May 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
AEROGEAR-8951
What
Add test coverage for gaps in serviceapp pkg
Why
Add test coverage
How
Add test coverage for gaps in serviceapp pkg
Verification Steps
Confirm tests complete successfully:
GOCACHE=off go test -cover github.com/aerogear/mobile-security-service-operator/pkg/controller/mobilesecurityserviceapp -v)Checklist:
Progress
Additional Notes