Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Full message test PR #6

Merged
merged 6 commits into from
Jun 11, 2020
Merged

Full message test PR #6

merged 6 commits into from
Jun 11, 2020

Conversation

secondsun
Copy link
Contributor

No description provided.

@secondsun secondsun mentioned this pull request Jun 9, 2020
Merged
@secondsun secondsun requested a review from ziccardi June 10, 2020 18:50
ziccardi
ziccardi suggested changes Jun 11, 2020
View reviewed changes
Copy link
Member

@ziccardi ziccardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some minor comment.
I believe the only important one is the one about removing the ...state.

react-native/push/App.js Outdated Show resolved Hide resolved
react-native/push/Notifications.js Outdated Show resolved Hide resolved
@secondsun @ziccardi
docs: apply suggestions from code review
32548cb 
Co-authored-by: Massimiliano Ziccardi <mziccard@redhat.com>
@secondsun secondsun merged commit 950f975 into aerogear:rn Jun 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ziccardi ziccardi ziccardi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@secondsun @ziccardi