This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
Aerogear 10074 #88
Merged
Aerogear 10074 #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
https://issues.jboss.org/browse/AEROGEAR-10074
What
Applying feedback from
Verification Steps
make installVerify that the operator monitoring resources have the service as an owner reference entry
Verify that the service monitoring resources have the UnifiedPushServer instance/cr as an owner reference
oc delete -f deploy/crds/push_v1alpha1_unifiedpushserver_cr.yamlVerify that the UnifiedPushServer owned GrafanaDashboard, PrometheusRule and ServiceMonitor are cleaned up.
oc delete -f deploy/operator.yamlVerify that the opearator owned GrafanaDashboard, PrometheusRule and ServiceMonitor are cleaned up.
Cleanup
make cluster/cleanChecklist:
Additional Notes
Image: quay.io/aerogear/unifiedpush-operator:dde4a2e