Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equation solver for Cubic & Quartic Equations #202

Merged
merged 10 commits into from
Jul 7, 2019

Conversation

mayankDhiman
Copy link

@mayankDhiman mayankDhiman commented Jun 23, 2019

Changelog:

  • Module for solving Cubic Equations using Determinant based formula added
  • Module for solving Quartic Equations using Determinant based formula added
  • polynomial/roots.py module restructured to incorporate equations of both types (Quadratic & Cubic)
  • Test cases for Cubic equation solver added.
  • A bug fixed

Issues Addressed:
Should fix #190 & #203

Examples:

@mayankDhiman mayankDhiman changed the title Equation solver for Cubic Equations Equation solver for Cubic & Quartic Equations Jun 27, 2019
Copy link
Member

@8hantanu 8hantanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍 !

tests/test_solvers.py Show resolved Hide resolved
tests/test_solvers.py Outdated Show resolved Hide resolved
visma/io/checks.py Outdated Show resolved Hide resolved
visma/solvers/polynomial/cubic.py Outdated Show resolved Hide resolved
@mayankDhiman mayankDhiman merged commit 1dd9911 into aerospaceresearch:dev Jul 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants