fixing concurrent access bug for BatchExecutor #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Brian,
We discovered an issues in our system when that our business threads are hanging forever, waiting for waitTillComplete() forever. Thread and Heap dumps have shown that all BatchThread instances has complete flag True, but BatchExecutor (owner class) has it set to False.
After some tests we discovered that there is concurrent access issue in threadCompleted() method, when traversing BatchThread instances without any protection.
This fix adds volatile flag for BatchThread.complete flag, which is checked in the cycle. Initial 2 hours test has shown 0 hanged threads, we started long stability test, however I think this fix should be enough to correct the problem.