FMWK-467 Issue using refs with yaml file #159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a policy specified either by defaultPolicy or using the policy hierarchy has a RecordExistsAction of CREATE_ONLY, the save method was overwriting this with REPLACE. Changed this to only replace the policy with REPLACE if the passed RecordExistsAction is UPDATE.
Whilst references work correctly with annotations, they would throw a NullPointerException when being used with an external configuration such as a YAML file. The issue was caused by the `BatchLoad` property which was initialized by default to true on the annotation but was left as null if not specified in the file
|
@tim-aero I have no problem with the refs with yaml file changes but this PR contains changes of #158 which we might not push to main at this point (we still haven't reviewed the refactor alternatives, didn't have the capacity and the user has a workaround for now).
|
roimenashe
changed the title
|
See #161 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a null pointer exception when using refs via the YAML file, caused by BatchLoad being null and reading code incorrectly assuming a valid value.