FMWK-467 Issue using refs with yaml file #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roimenashe
commented
Jun 19, 2024
src/main/java/com/aerospike/mapper/tools/configuration/ReferenceConfig.java
Show resolved
Hide resolved
roimenashe
commented
Jun 19, 2024
| typeMapper = new ObjectReferenceMapper(ClassCache.getInstance().loadClass(clazz, mapper), ref.getLazy(), ref.getBatchLoad(), ref.getType(), mapper); | ||
| typeMapper = new ObjectReferenceMapper( | ||
| ClassCache.getInstance().loadClass(clazz, mapper), | ||
| ref.getLazy() == null ? false : ref.getLazy(), |
There was a problem hiding this comment.
Can we assign defaults for lazy and batchLoad in ReferenceConfig class? that way if another place requires defaults it will be taken from a single point of truth
There was a problem hiding this comment.
After consulting with Tim, we can improve it but at some point we will need a refactor of yaml/annotation config reading which will affect this place as well - I'm ok with the scope of this PR just because its only a single place of null check but later we will probably want to refactor/improve/clean some areas of the Java Object Mapper including this specific flow
# Conflicts: # src/main/java/com/aerospike/mapper/tools/configuration/ClassConfig.java
reugn
approved these changes
Jul 3, 2024
tim-aero
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tim: "Fixed a null pointer exception when using refs via the YAML file, caused by BatchLoad being null and reading code incorrectly assuming a valid value."