Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add external object gps #231

Closed
wants to merge 2 commits into from
Closed

Add external object gps #231

wants to merge 2 commits into from

Conversation

javilinos
Copy link
Collaborator

@javilinos javilinos commented Apr 26, 2023


Basic Info

Info Please fill out this column
Issue(s) this addresses #230 #229 #228
ROS2 version tested on Humble
Aerial platform tested on Ignition

Description of contribution in a few bullet points

  • Gps moved to Nacelle frame
  • Gps alligned to Nacelle frame
  • Gps alligned in ENU Frame
  • ground truth plugin supports gps (dev will be in other branch)

Future work that may be required in bullet points

  • Origin is placed in 0,0 cartessian coordinate by the simulator, origin should be set by service or parameter (pref parameter)
  • Build odom->base_link frame with the Inverse(map->odom) * Inverse(earth->map) * (earth->base_link) as we are receiving this last transformation as information coming from the simulation.

@javilinos javilinos requested a review from pariaspe April 26, 2023 10:19
@javilinos javilinos self-assigned this Apr 26, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #231 (e18ca20) into main (cfa0eb5) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head e18ca20 differs from pull request most recent head 1d6faf8. Consider uploading reports for the commit 1d6faf8 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff            @@
##            main    #231      +/-   ##
========================================
- Coverage   3.07%   3.04%   -0.03%     
========================================
  Files        100     100              
  Lines       5244    5287      +43     
  Branches     451     451              
========================================
  Hits         161     161              
- Misses      4945    4988      +43     
  Partials     138     138              
Flag Coverage Δ
unittests 3.04% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
as2_core/include/as2_core/sensor.hpp 0.00% <0.00%> (ø)
...ss_controller/differential_flatness_controller.hpp 0.00% <ø> (ø)
...ontroller/src/differential_flatness_controller.cpp 0.00% <0.00%> (ø)
...ator/plugins/ground_truth/include/ground_truth.hpp 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@javilinos
Copy link
Collaborator Author

Solved in PR #278 and PR #279

@javilinos javilinos closed this Jun 7, 2023
@javilinos javilinos deleted the add_external_object_gps branch July 13, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants