Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build the NUTS kernel with a logprob function #31

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Conversation

rlouf
Copy link
Member

@rlouf rlouf commented Sep 22, 2021

We currently need to provide a potential function to build the NUTS kernel. However, end users are used to working with logprobs and not potentials so this might be confusing. We thus now require a logpropb function to build the NUTS kernel (it is already the case for the HMC kernel).

Closes #30

@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #31 (ce97903) into main (88a4538) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #31   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          344       345    +1     
  Branches        14        14           
=========================================
+ Hits           344       345    +1     
Impacted Files Coverage Δ
aehmc/nuts.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88a4538...ce97903. Read the comment docs.

@brandonwillard brandonwillard merged commit 0d1d7c1 into main Sep 22, 2021
@brandonwillard brandonwillard deleted the nuts-logprob branch September 22, 2021 17:38
@brandonwillard brandonwillard added the refactoring A change that improves the codebase but doesn't necessarily introduce a new feature label Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring A change that improves the codebase but doesn't necessarily introduce a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nuts.kernel should take a logprob_fn as an argument
3 participants