New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement step-size adaptation #41
Conversation
Codecov Report
@@ Coverage Diff @@
## main #41 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 12 +2
Lines 396 442 +46
Branches 19 23 +4
=========================================
+ Hits 396 442 +46
Continue to review full report at Codecov.
|
207e7d1
to
8898d54
Compare
e87e2b8
to
783c775
Compare
We make HMC return the acceptance probability related to the step that was just taken.
40d49e9
to
5f4d652
Compare
58ab8ba
to
8ad2fa5
Compare
8ad2fa5
to
aee5be3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but we definitely need to fix those Aesara errors that are showing up in the notebook.
I agree. #42 was supposed to keep track of the error, but I need to fix it so the tests fail. PS: Nothing changed in the PR, I just rebased the branch on main. |
In this PR we implement the following step-size adaptation algorithms:
This PR closes #40 as well.