Skip to content

Conversation

@rlouf
Copy link
Member

@rlouf rlouf commented Oct 14, 2021

This PR is to track the warning found in #29. We set the on_shape_error config variable to raise in the CI; the tests will fail until the underlying issue is fixed.

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #42 (712cbfb) into main (8a634df) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #42   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        12    +2     
  Lines          385       442   +57     
  Branches        17        23    +6     
=========================================
+ Hits           385       442   +57     
Impacted Files Coverage Δ
aehmc/hmc.py 100.00% <0.00%> (ø)
aehmc/nuts.py 100.00% <0.00%> (ø)
aehmc/metrics.py 100.00% <0.00%> (ø)
aehmc/trajectory.py 100.00% <0.00%> (ø)
aehmc/step_size.py 100.00% <0.00%> (ø)
aehmc/window_adaptation.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a634df...712cbfb. Read the comment docs.

brandonwillard
brandonwillard previously approved these changes Oct 14, 2021
@rlouf
Copy link
Member Author

rlouf commented Oct 21, 2021

I am not sure why this is not raising an exception ? Running pytest tests/test_hmc.py locally will raise an exception as expected, but running pytest or pytest tests won't. print(aesara.config.on_shape_error) always returns raise.

@rlouf
Copy link
Member Author

rlouf commented Oct 26, 2021

I added on_opt_error=raise and still get the same behavior.

@brandonwillard brandonwillard added enhancement New feature or request testing labels Oct 26, 2021
@brandonwillard
Copy link
Member

I added on_opt_error=raise and still get the same behavior.

Which test is expected to fail again? Everything seems to pass for me locally as well.

@brandonwillard brandonwillard removed the enhancement New feature or request label Oct 26, 2021
@rlouf
Copy link
Member Author

rlouf commented Oct 27, 2021

test_hmc.py is supposed to fail. It does when I run pytest tests/test_hmc.py but not when I simply run pytest.

@brandonwillard
Copy link
Member

test_hmc.py is supposed to fail. It does when I run pytest tests/test_hmc.py but not when I simply run pytest.

Oh, interesting; I'll try that locally.

@brandonwillard brandonwillard merged commit abcc618 into main Dec 10, 2021
@brandonwillard brandonwillard deleted the shape-error branch December 10, 2021 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants