-
-
Notifications
You must be signed in to change notification settings - Fork 6
Raise exception on shape error in CI #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #42 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 12 +2
Lines 385 442 +57
Branches 17 23 +6
=========================================
+ Hits 385 442 +57
Continue to review full report at Codecov.
|
|
I am not sure why this is not raising an exception ? Running |
|
I added |
Which test is expected to fail again? Everything seems to pass for me locally as well. |
|
|
Oh, interesting; I'll try that locally. |
This PR is to track the warning found in #29. We set the
on_shape_errorconfig variable toraisein the CI; the tests will fail until the underlying issue is fixed.