Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt new behavior of System.console() since JDK22 #69

Merged
merged 2 commits into from
May 30, 2024

Conversation

Eng-Fouad
Copy link
Contributor

Resolves #68

@Eng-Fouad
Copy link
Contributor Author

@stalep @tristantarrant @karlll @jfdenise @iweiss

Could you please review this PR? It will fix this bug in Quarkus: quarkusio/quarkus#39575

@stalep stalep merged commit b66e7f0 into aeshell:master May 30, 2024
@stalep
Copy link
Member

stalep commented May 30, 2024

Thank for the pr @Eng-Fouad, sorry it took so long to get it merged!

@Eng-Fouad
Copy link
Contributor Author

Eng-Fouad commented May 30, 2024

Thank for the pr @Eng-Fouad, sorry it took so long to get it merged!

Thanks for accepting the PR. Will be there any new release soon (v2.6)?

@Eng-Fouad
Copy link
Contributor Author

Eng-Fouad commented May 30, 2024

@stalep I noticed that version 2.5 was not published to maven central before. So this PR will be included in 2.5 once published, right? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt new behavior of System.console() since JDK22
3 participants