Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes error handing, example:
There are two changes. First of all we had an issue that this was not working at all and throwing like this:
This happens because the error handling in
lib/kaffy/resource_callbacks.ex
wraps the "unexpected" errors in the error tuple, which is pointless when the error is already an error tuple. For example this results in{:error, {:error, Ecto.Changeset.t()}}
tuple which can't be then handled correctly.Second after I fixed this I noticed the errors are not displayed in details so this was the second part of the fix. You can notice I added a simple helper function -
add_class/2
which basically appends the class in the opts instead of overwriting it every time. We have even places where we put the new class one after another which makes the old value redundant.