-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct url in openapi specs #1837
Conversation
Have you tried this with the staging/prod setup? I don't think this works as intended, we are running the middleware app under the |
Ah, it seems you are correct, I will try something else then, thank you. |
a8ab2e0
to
9c2c5ff
Compare
@@ -98,6 +98,7 @@ COPY config/runtime.exs config/ | |||
|
|||
# Generate swagger V2 file | |||
RUN mix run --no-start -e 'IO.puts(Mix.Project.config[:version])' >AEMDW_VERSION | |||
ARG PATH_PREFIX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think ARGs in dockerfiles are env variables. This wouldn't be accessed on the swagger script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are, for RUN
commands: https://docs.docker.com/reference/dockerfile/#using-arg-variables . If you wanna test it, you can rebuild the docker container using the docker-compose-dev.yml
included in the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, it works the same! sorry, merging
refs: #1759
Decided to go with the second proposed solution, it would seem to work for the different cases and it would not require additional configurations.