Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct url in openapi specs #1837

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Conversation

vatanasov
Copy link
Contributor

refs: #1759
Decided to go with the second proposed solution, it would seem to work for the different cases and it would not require additional configurations.

@vatanasov vatanasov self-assigned this Jul 9, 2024
@sborrazas
Copy link
Contributor

Have you tried this with the staging/prod setup? I don't think this works as intended, we are running the middleware app under the /mdw/ namespace via an nginx proxy, which removes the /mdw/ from the path to call the middleware app, which is how the middleware responds

@vatanasov
Copy link
Contributor Author

Have you tried this with the staging/prod setup? I don't think this works as intended, we are running the middleware app under the /mdw/ namespace via an nginx proxy, which removes the /mdw/ from the path to call the middleware app, which is how the middleware responds

Ah, it seems you are correct, I will try something else then, thank you.

@vatanasov vatanasov force-pushed the correct-url-in-openapi-specs branch from a8ab2e0 to 9c2c5ff Compare July 11, 2024 08:17
@@ -98,6 +98,7 @@ COPY config/runtime.exs config/

# Generate swagger V2 file
RUN mix run --no-start -e 'IO.puts(Mix.Project.config[:version])' >AEMDW_VERSION
ARG PATH_PREFIX
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think ARGs in dockerfiles are env variables. This wouldn't be accessed on the swagger script

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are, for RUN commands: https://docs.docker.com/reference/dockerfile/#using-arg-variables . If you wanna test it, you can rebuild the docker container using the docker-compose-dev.yml included in the PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, it works the same! sorry, merging

@sborrazas sborrazas merged commit bb895ed into master Jul 17, 2024
7 checks passed
@sborrazas sborrazas deleted the correct-url-in-openapi-specs branch July 17, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants