-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update node to version 6.13 #1732
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
f7fc4a1
chore: update node to version 6.13
vatanasov ce8d5cd
fix: formatting and credo checks
vatanasov 0226bfd
fix: ssl_verify_fun version bump for elixir 1.15
vatanasov 58812a4
fix: runner image version
vatanasov 92dfadd
fix: char representation
vatanasov d24f4b0
fix: dialyzer version and some failing tests
vatanasov 5fb0449
fix: return global state to initial state
vatanasov 8c20f56
fix: using rocksdb as fallbackstore in tests
vatanasov 153765d
fix: make oracle tests not use rocksdb
vatanasov 944dd98
fix: make async_store mockable
vatanasov 6524c1c
fix: tests relying on order in maps
vatanasov 5d115ed
fix: dialyzer errors
vatanasov 60ca3bd
fix: credo error
vatanasov 016bafb
fix: potentially fix pipeline error
vatanasov 77f789e
fix: clean up global state after test
vatanasov df04bd7
fix: better pattern match on message
vatanasov 93e1bdc
fix: wait out the broadcaster in the tests
vatanasov 3d6c57f
fix: credo issues
vatanasov 8ed6eb7
fix: restore previous state of the test
vatanasov 367d3f1
fix: explicitly name unused variable
vatanasov d6e1351
fix: revert async store type to opaque
vatanasov 4feee8e
fix: remove unused alias
vatanasov af4ac00
fix: comment out randomly failing test
vatanasov 75c2872
fix: close describe block
vatanasov 72aa25f
fix: remove todo from a comment
vatanasov c0fd06a
fix: change versions in .tool-versions
vatanasov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
erlang 23.3.4.17 | ||
elixir 1.13.4-otp-23 | ||
erlang 26.2.3 | ||
elixir 1.16.2-otp-26 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -125,9 +125,9 @@ defmodule AeMdw.Db.RocksDb do | |
""" | ||
@spec dirty_iterator(transaction(), table(), Keyword.t()) :: {:ok, iterator()} | {:error, any()} | ||
def dirty_iterator(transaction, table, read_options \\ []) do | ||
{db_ref, cf_ref} = cf_refs(table) | ||
{_db_ref, cf_ref} = cf_refs(table) | ||
|
||
:rocksdb.transaction_iterator(db_ref, transaction, cf_ref, read_options) | ||
:rocksdb.transaction_iterator(transaction, cf_ref, read_options) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a change in the library itself, related to this commit: https://gitlab.com/barrel-db/erlang-rocksdb/-/commit/d250d366e240256a84ecc91102bb2e62758b0c71?view=parallel |
||
end | ||
|
||
@doc """ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change, and all that follows, where
async_state
is explicitly passed (and stored, in the case ofAsyncStoreServer
) are made so that the state can be reliably mocked and not relied on the global one.