Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: generalize aex9 meta info with aexn contract #667

Merged
merged 5 commits into from
May 16, 2022
Merged

refactor: generalize aex9 meta info with aexn contract #667

merged 5 commits into from
May 16, 2022

Conversation

jyeshe
Copy link
Member

@jyeshe jyeshe commented May 5, 2022 •
edited
Loading

What

  • Moves metadata from RevAex9Contract to AexnContract
  • Replace usage of RevAex9Contract for rendering
  • Shared fetch and rendering for Aex9 and Aex141

Why

Refs #629

Notes

  • RevAex9Contract will be completely removed after handling forks/invalidations in a generalized way for Aex9 and Aex141

@jyeshe jyeshe changed the base branch from master to aexn-pubkeys May 5, 2022 14:19
@jyeshe jyeshe force-pushed the aexn-meta-info branch 2 times, most recently from c263730 to d9b610e Compare May 5, 2022 19:01
@jyeshe jyeshe force-pushed the aexn-meta-info branch 2 times, most recently from 1e9fb18 to d162ed9 Compare May 5, 2022 19:10
@jyeshe jyeshe self-assigned this May 5, 2022
@jyeshe jyeshe marked this pull request as ready for review May 5, 2022 19:18
@jyeshe jyeshe requested review from sborrazas and thepiwo May 5, 2022 19:18
sborrazas
sborrazas requested changes May 5, 2022
View reviewed changes
lib/ae_mdw_web/websocket/socket_handler.ex Outdated Show resolved Hide resolved
test/ae_mdw/aexn_tokens_test.exs Outdated Show resolved Hide resolved
@jyeshe jyeshe requested a review from sborrazas May 6, 2022 07:46
@jyeshe jyeshe mentioned this pull request May 13, 2022
Merged
Base automatically changed from aexn-pubkeys to master May 16, 2022 11:39
@jyeshe jyeshe merged commit 71dc396 into master May 16, 2022
@jyeshe jyeshe deleted the aexn-meta-info branch May 16, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sborrazas sborrazas sborrazas approved these changes

@thepiwo thepiwo thepiwo approved these changes

Assignees

@jyeshe jyeshe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jyeshe @sborrazas @thepiwo