Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove rocksdb wrapping code that created DB inconsistencies #865

Merged
merged 1 commit into from
Aug 30, 2022
Merged

fix: remove rocksdb wrapping code that created DB inconsistencies #865

merged 1 commit into from
Aug 30, 2022

Conversation

sborrazas
Copy link
Contributor

This will allow deleting records created inside the transaction and
non-existent values.

@sborrazas
fix: remove rocksdb wrapping code that created DB inconsistencies
f84f24f 
This will allow deleting records created inside the transaction and
non-existent values.
@sborrazas sborrazas self-assigned this Aug 24, 2022
jyeshe
jyeshe approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@jyeshe jyeshe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me at this moment to get rid of the write-through and read-through Mnesia-like behaviours.

@sborrazas sborrazas merged commit 530add4 into master Aug 30, 2022
@sborrazas sborrazas deleted the rocksdb-consistency branch August 30, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thepiwo thepiwo thepiwo approved these changes

@jyeshe jyeshe jyeshe approved these changes

Assignees

@sborrazas sborrazas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sborrazas @thepiwo @jyeshe