Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out how to sign delegation signatures using aepp-wallet connection #1758

Closed
davidyuk opened this issue Feb 10, 2023 · 5 comments · Fixed by #1867
Closed

Figure out how to sign delegation signatures using aepp-wallet connection #1758

davidyuk opened this issue Feb 10, 2023 · 5 comments · Fixed by #1867
Labels
Milestone

Comments

@davidyuk
Copy link
Member

davidyuk commented Feb 10, 2023

Currently, it is not allowed to sign raw data using wallet.

I would pass its components as plain text to be able to validate it on the on wallet side, otherwise would be difficult to distinguish buffer with account address and contract address.

@marc0olo
Copy link
Contributor

I guess that will be highly relevant for the UI of my proposed grant, right? https://forum.aeternity.com/t/new-wrapping-aens-names-into-aex-141-nfts/11214

@davidyuk davidyuk added this to the next milestone Jun 26, 2023
@subhod-i
Copy link
Collaborator

Wallet does support signing raw data now. @CedrikNikita please confirm

@marc0olo
Copy link
Contributor

@davidyuk it would be great if you can provide me a short example how to pass the raw data correctly to the wallet for a valid delegation signature for AENS names :)

@CedrikNikita
Copy link
Collaborator

CedrikNikita commented Jul 21, 2023

Wallet does support signing raw data now. @CedrikNikita please confirm

Yes, but we are signing it by our own. And the topic here is related to make it possible with a sdk.

@davidyuk
Copy link
Member Author

davidyuk commented Jul 24, 2023

I've found a potential security vulnerability in the delegation signature for oracle query aeternity/aesophia#474
aeternity/aesophia#475
but it is not blocking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants