Delegation signature over aepp-wallet connection #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To revert breaking change done in 13.1.0
In consistency with `signTransaction`.
davidyuk
force-pushed
the
feature/delegation-over-aepp-wallet
branch
from
7f2aede
to
30fad96
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1867 +/- ##
===========================================
- Coverage 82.32% 81.36% -0.97%
===========================================
Files 94 94
Lines 3310 3380 +70
Branches 656 681 +25
===========================================
+ Hits 2725 2750 +25
- Misses 275 302 +27
- Partials 310 328 +18
☔ View full report in Codecov by Sentry. |
|
with SH wallet I am currently running into a timeout using this branch in an aepp. I guess there is some update on SH wallet side needed, right? |
Yep. Currently, delegation signatures is not supported in aepp-wallet connections, the latest version of SH doesn't know anything about them |
|
@davidyuk having problems testing the examples locally, but can't see any obvious issue. feel free to go ahead |
marc0olo
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1758
This PR is supported by the Æternity Crypto Foundation
Test UI added to aepp example
The last time I try to move
createDelegationSignatureto Contract, now I'm moving it to AccountBase 🙃 This is need to be in accordance with the current aepp-wallet permission model.