Skip to content
This repository has been archived by the owner on Aug 12, 2024. It is now read-only.

add cli command: account sign-data #262

Closed
wants to merge 6 commits into from
Closed

Conversation

noandrea
Copy link
Contributor

Allow the signature of arbitrary data

references: #261

@noandrea noandrea modified the milestones: 5.1.0, 6.1.0 Oct 12, 2019
@shekhar-shubhendu shekhar-shubhendu modified the milestones: 6.1.0, 6.2.0 Nov 20, 2019
@shekhar-shubhendu shekhar-shubhendu modified the milestones: 6.2.0, 6.3.0 Nov 28, 2019
@codecov
Copy link

codecov bot commented Jan 29, 2020

Codecov Report

Merging #262 into develop will increase coverage by 0.17%.
The diff coverage is 93.1%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #262      +/-   ##
===========================================
+ Coverage     77.9%   78.07%   +0.17%     
===========================================
  Files           17       17              
  Lines         2752     2778      +26     
===========================================
+ Hits          2144     2169      +25     
- Misses         608      609       +1
Impacted Files Coverage Δ
aeternity/identifiers.py 100% <100%> (ø) ⬆️
aeternity/utils.py 95.08% <100%> (+0.53%) ⬆️
aeternity/signing.py 95.48% <100%> (+0.91%) ⬆️
aeternity/__main__.py 62.83% <87.5%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 154cde7...fa824be. Read the comment docs.

@noandrea noandrea marked this pull request as ready for review January 30, 2020 01:01
@noandrea noandrea added the breaking-changes It's going to hurt label Jan 30, 2020
Allow the signature of arbitrary data

references: #261
BREAKING CHANGE: the account.verify method is now consistent with
is_signature_valid
@noandrea noandrea modified the milestones: 7.0.0, 7.1.0 Jan 31, 2020
@noandrea noandrea added enhancement New feature or request and removed breaking-changes It's going to hurt labels Jan 31, 2020
@noandrea
Copy link
Contributor Author

🤷

@noandrea noandrea closed this May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants