Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RocksDB to the project skeleton #42

Closed
joelreymont opened this issue Aug 30, 2017 · 5 comments
Closed

Add RocksDB to the project skeleton #42

joelreymont opened this issue Aug 30, 2017 · 5 comments
Assignees

Comments

@joelreymont
Copy link
Contributor

No description provided.

@joelreymont joelreymont added the 1d label Aug 30, 2017
@joelreymont joelreymont added this to the Sprint 1 milestone Aug 30, 2017
@lucafavatella
Copy link
Contributor

From #2 (comment) :

We should use RocksDB instead via the Erlang bindings.

I see there are two RocksDB bindings on hex:

@lucafavatella
Copy link
Contributor

I am writing here my state on this so far. Next steps are:

  • Summarize differences in the two forks. Draft notes:
    • One seems more stable, the other one more feature rich for the sake of operations (e.g. backup, snapshot);
    • To be checked whether Erlang API is the same;
    • Identify kind of integration i.e. NF, dirty.
  • Select one;
  • Attempt inclusion in project. The two bindings have different build system (rebar vs. rebar3) so the other could be taken for easing integration.

I see there are two RocksDB bindings on hex:

They diverged a year ago - see 1 that is the same as 2.

In the following is a summary of the differences:

leo-project/erocksdb barrel-db/erlang-rocksdb
Build system rebar rebar3
RocksDB version 4.13.5 5.7.2
Retrieval of C deps Downloaded by script called by rebar hook Committed in the git repository itself

@joelreymont
Copy link
Contributor Author

What do you recommend?

lucafavatella pushed a commit that referenced this issue Sep 1, 2017
Also delete duplicated lager dependency.
@joelreymont joelreymont removed this from the Sprint 1 milestone Sep 1, 2017
@lucafavatella lucafavatella removed their assignment Sep 1, 2017
@lucafavatella
Copy link
Contributor

lucafavatella commented Sep 1, 2017

The work-in-progress branch for this ticket:
https://github.com/aeternity/epoch/tree/gh-42-add-rocksdb-wip (a8247f3).

lucafavatella pushed a commit that referenced this issue Sep 1, 2017
…' and 'origin/gh-3-coinbase-tx' into gh-29-merkle-tree-wip
@lucafavatella lucafavatella self-assigned this Sep 5, 2017
sennui added a commit that referenced this issue Sep 5, 2017
Solves GH-42 Refresh rebar lock (unlock, tree, lock)
@lucafavatella
Copy link
Contributor

What do you recommend?

I expressed my recommendation, and motivations, in PR 57.

@sennui sennui closed this as completed in #57 Sep 6, 2017
sennui added a commit that referenced this issue Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants