Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do you follow SemVer? If yes, can you mention it in README/Changelog? #57

Closed
pravi opened this issue Mar 23, 2018 · 1 comment
Closed

Do you follow SemVer? If yes, can you mention it in README/Changelog? #57

pravi opened this issue Mar 23, 2018 · 1 comment

Comments

@pravi
Copy link
Contributor

pravi commented Mar 23, 2018

Most projects assume there is no SemVer when there is no explicit declaration. So kubeclient has ~> 1.0.4 as requirement for recursive-open-struct. This means I have to maintain a patch in debian to be able to install 1.1.0 version. If you state your semver compliance, I can ask kubeclient maintainer to relax the dependency to ~> 1.0.
pravi added a commit to pravi/kubeclient that referenced this issue Mar 23, 2018
@pravi
Update recursive-open-struct dependency
53031c3 
They have not introduced a breaking change in the past in minor releases https://github.com/aetherknight/recursive-open-struct/blob/master/CHANGELOG.md

Asking them to be sure aetherknight/recursive-open-struct#57 Debian already has 1.1.0 and it would be good to sync versions
@pravi pravi mentioned this issue Mar 23, 2018
Merged
pravi added a commit to pravi/kubeclient that referenced this issue Mar 23, 2018
@pravi
Update recursive-open-struct dependency to ~> 1.0, >= 1.0.4
09f3204 
They have not introduced a breaking change in the past in minor releases https://github.com/aetherknight/recursive-open-struct/blob/master/CHANGELOG.md

Asking them to be sure aetherknight/recursive-open-struct#57 Debian already has 1.1.0 and it would be good to sync versions
@aetherknight
Copy link
Owner

Hey @pravi recursive-open-struct does follow semver. I will add a statement about it to the readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aetherknight @pravi