Fix average monthly income calculation #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromecornet
changed the title
|
To fix the overall calculation as well as to take into account history starting less than 2 years ago, I ended up adding a query to figure out the date of the oldest transactions so that the correct number of months is taken into account (i.e. less than 12 for previous year/2 years ago if the history doesn't go that far) |
jeromecornet
force-pushed
the
fix_monthly_calculation
branch
2 times, most recently
from
7e5106c
to
37355ba
Compare
jeromecornet
force-pushed
the
fix_monthly_calculation
branch
from
37355ba
to
df98a61
Compare
|
Merci @jeromecornet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of months for monthly average income calculation only takes into account the months where there is an actual income. So if there is a month with no income (for example last year), the 'monthly average' gets artificially bumped up.
This simplifies the calculation to use the actual number of months in the given year (current month number for the current year, 12 for previous years) rather than only the months where there was some income