fix: repository URLs in style of 'git+http'

afbobak · Jun 2, 2015 · 1aefc5e · 1aefc5e
1 parent 9c57683
commit 1aefc5e
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 1 deletion.
diff --git a/lib/pkg.js b/lib/pkg.js
@@ -147,6 +147,11 @@ exports.enhancePackage = function (pkg) {
       repository.href = href;
     } else if (repository.url.indexOf("http") === 0) {
       repository.href = repository.url;
+    } else if (repository.url.indexOf("git+") === 0) {
+      href = repository.url.
+        replace("git+", "").
+        replace(".git", "/");
+      repository.href = href;
     }
   }
   pkg.repository = repository;

diff --git a/test/pkg-test.js b/test/pkg-test.js
@@ -88,7 +88,7 @@ describe("pkg-test - getPackage", function () {
       versions : {
         "0.0.1" : {
           name    : "pkg",
-          version : "0,0.1"
+          version : "0.0.1"
         }
       }
     };
@@ -1516,3 +1516,35 @@ describe('package npm functions', function () {
     });
   });
 });
+
+
+// ==== Test Case
+
+describe("pkg-test - enhancePackage", function () {
+  var sandbox;
+
+  beforeEach(function () {
+    sandbox = sinon.sandbox.create();
+  });
+
+  afterEach(function () {
+    sandbox.restore();
+  });
+
+  it("should have function", function () {
+    assert.isFunction(pkg.enhancePackage);
+  });
+
+  it("should convert git+http", function () {
+    var pkgMeta = {
+      name : 'test',
+      repository : { url : 'git+https://github.com/test.git' },
+      versions : { "0.0.1" : { name : "pkg", version : "0.0.1" } },
+      "dist-tags" : { latest : "0.0.1" }
+    };
+
+    pkg.enhancePackage(pkgMeta);
+
+    assert.equal(pkgMeta.repository.href, 'https://github.com/test/');
+  });
+});