FolderNameFilter: support messages that exist in multiple locations #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In handle_message, tag a message on the basis of the folder names in *all* the filesystem paths for that message. This improves support in particular for GMail, where the same message may be stored in several different directories. Notmuch knows to group these together, and notmuch.message.Message.get_filenames() returns all the paths for the given message. This change simply runs the previous code in a loop over these paths.
|
Oh shoot, I see that a very similar PR is already open: #145. My patch takes a different (slightly more naive) approach. Closing...sorry for the noise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In handle_message, tag a message on the basis of the folder names
in all the filesystem paths for that message.
This improves support in particular for GMail, where the same message
may be stored in several different directories. Notmuch knows to
group these together, and notmuch.message.Message.get_filenames()
returns all the paths for the given message. This change simply runs
the previous code in a loop over these paths.