Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get notmuch database path using Database wrapper #321

Conversation

aya
Copy link
Contributor

@aya aya commented Dec 6, 2021

It fixes #303 and closes #267, allowing FolderNameFilter to work with
relative path in database.path of notmuch config file.

It fixes afewmail#303 and closes afewmail#267, allowing FolderNameFilter to work with
relative path in database.path of notmuch config file.
@codecov
Copy link

codecov bot commented Dec 12, 2021

Codecov Report

Merging #321 (5a67af3) into master (2ebc909) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
- Coverage   47.03%   46.98%   -0.05%     
==========================================
  Files          30       30              
  Lines        1080     1079       -1     
==========================================
- Hits          508      507       -1     
  Misses        572      572              
Flag Coverage Δ
unittests 46.98% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
afew/filters/FolderNameFilter.py 20.93% <ø> (-1.80%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ebc909...5a67af3. Read the comment docs.

Copy link
Collaborator

@GuillaumeSeren GuillaumeSeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuillaumeSeren GuillaumeSeren merged commit aa6661d into afewmail:master Dec 12, 2021
@GuillaumeSeren
Copy link
Collaborator

Thank you for the patch @aya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relative path in database.path of notmuch config breaks FolderNameFilter
2 participants