Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add check for afids_to_fcsv #9

Closed
kaitj opened this issue Jun 30, 2023 · 0 comments · Fixed by #10
Closed

[ENH] Add check for afids_to_fcsv #9

kaitj opened this issue Jun 30, 2023 · 0 comments · Fixed by #10
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@kaitj
Copy link
Contributor

kaitj commented Jun 30, 2023

Describe the feature you'd like to see
Currently the afids_utils.io.afids_to_fcsv function writes a (32, 3) NumPy array to an fcsv file based on the template. The 32 AFIDs expected in this function is not a hard rule and is based off of the number of AFIDs expected in the provided template. In the future, we may expect a different number of AFIDs due to subsetting of existing fiducials or even for different species.

To that end, a couple of checks should be implemented in this function to:

  1. Confirm that the number of AFIDs (e.g. 32) matches the number of expected number of AFIDs in the template
  2. Check that the second dimension is equal to the 3 expected spatial dimensions (x, y, z)
@kaitj kaitj added enhancement New feature or request good first issue Good for newcomers labels Jun 30, 2023
@kaitj kaitj self-assigned this Jul 17, 2023
@kaitj kaitj closed this as completed in #10 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant