Add checks / tests for AFIDs coord array shape #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaitj
added
the
maintenance
kaitj
force-pushed
the
maint/io/afids_to_fcsv
branch
from
9d911aa
to
e252a64
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 133 156 +23
=========================================
+ Hits 133 156 +23
|
tkkuehn
requested changes
Jul 31, 2023
tkkuehn
reviewed
Jul 31, 2023
kaitj
force-pushed
the
maint/io/afids_to_fcsv
branch
3 times, most recently
from
35b889a
to
39e277b
Compare
Check to make sure the number of afids (shape[0]) and the spatial dimensions (shape[1]) match what is expected from the template. This commit additionally adds tests to check for the invalid cases by drawing from invalid integers and asserting a substring of the error message is raised.
- Removed `delete=False` in tests where temp file is not explicitly removed
kaitj
force-pushed
the
maint/io/afids_to_fcsv
branch
from
39e277b
to
f964fd7
Compare
tkkuehn
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Check to make sure the number of afids (
shape[0]) and the spatial dimensions (shape[1]) match what is expected from the template. This isn't strictly necessary with current code-base, but looking to future proof it if we add other species or subsets of fiducials.Additionally adds tests to check for the invalid cases by drawing from invalid integers and asserting a substring of the error message is raised.
Closes #9.
Note: The actions checks will always fail due to failed build of the docs (which have not yet been merged and are not part of this PR)
Types of changes
What types of changes does your code introduce? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!poe qualitytaskNotes
All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.